Max Semenik [Fri, 19 Nov 2010 20:34:44 +0000 (20:34 +0000)]
SQLite types can be non-nullable
Markus Glaser [Fri, 19 Nov 2010 14:12:54 +0000 (14:12 +0000)]
sample configuration to run selenium against a grid server
Markus Glaser [Fri, 19 Nov 2010 14:12:07 +0000 (14:12 +0000)]
fixed broken path
Alexandre Emsenhuber [Fri, 19 Nov 2010 11:49:47 +0000 (11:49 +0000)]
@fixme command doesn't exist in doxygen
Alexandre Emsenhuber [Fri, 19 Nov 2010 10:53:08 +0000 (10:53 +0000)]
* (bug 25987) prop=info&inprop=watched now also works for missing pages
Tim Starling [Fri, 19 Nov 2010 10:41:06 +0000 (10:41 +0000)]
* Made Resources.php return a pure-data array instead of an ugly mix of data and code. This allows the class code to be lazy-loaded with the autoloader, for a performance advantage especially on non-APC installs. And using the convention where if the class is omitted, ResourceLoaderFileModule is assumed, the registration code becomes shorter and simpler.
* Modified ResourceLoader to lazy-initialise module objects, for a further performance advantage.
* Deleted ResourceLoader::getModules(), provided getModuleNames() instead. Although the startup module needs this functionality, it's slow to generate, so to avoid misuse, it's better to provide a foolproof fast interface and let the startup module do the slow thing itself.
* Modified ResourceLoader::register() to optionally accept an info array instead of an object.
* Added $wgResourceModules, allowing extensions to efficiently define their own resource loader modules. The trouble with hooks is that they contain code, and code is slow. We've been through all this before with i18n. Hooks are useful as a performance tool only if you call them very rarely.
* Moved ResourceLoader settings to their own section in DefaultSettings.php
* Added options to ResourceLoaderFileModule equivalent to the $localBasePath and $remoteBasePath parameters, to allow it to be instantiated via the new array style. Also added remoteExtPath, which allows modules to be registered before $wgExtensionAssetsPath is known.
* Added OutputPage::getResourceLoader(), mostly for debugging.
* The time saving at the moment is about 5ms per request with no extensions, which is significant already with 6 load.php requests for a cold cache page view. This is a much more scalable interface; the relative saving will grow as more extensions are added which use this interface, especially for non-APC installs.
Although the interface is backwards compatible, extension updates will follow in a subsequent commit.
Tim Starling [Fri, 19 Nov 2010 06:52:38 +0000 (06:52 +0000)]
* In ResourceLoaderContext, lazy-load $this->direction and $this->language, to avoid loading the whole English localisation for load.php requests which never call getHash().
* Interpreted some Trevor-speak in the doc comment of ResourceLoader::preloadModuleInfo().
* Made setMsgBlobMtime() (called from preloadModuleInfo()) actually work, by making getMsgBlobMtime() use the cached blob times if they are available.
Tim Starling [Fri, 19 Nov 2010 06:49:15 +0000 (06:49 +0000)]
* Some tweaks to wfMemoryLimit() to make it a bit faster.
* Fixed inappropriate use of empty(), added "break missing" comments as in zend_atol()
Derk-Jan Hartman [Fri, 19 Nov 2010 01:40:56 +0000 (01:40 +0000)]
Followup to r76867. Only add canonical if there is no local page for the shared file.
Bug 25960
Tim Starling [Fri, 19 Nov 2010 01:40:00 +0000 (01:40 +0000)]
Use wfGetCache( CACHE_ANYTHING ) instead of $wgMemc to store the result of ResourceLoader::filter(). Speeds up cold cache view of the main page on a non-APC default installation by a factor of 2.3 (measured using siege, no concurrency, URL list captured from Firefox, server = my laptop).
Tim Starling [Fri, 19 Nov 2010 01:31:53 +0000 (01:31 +0000)]
Break long lines
Tim Starling [Fri, 19 Nov 2010 01:31:16 +0000 (01:31 +0000)]
* In CoreInstaller, fixed notice when extensions are present, due to incorrect format of extensions callback entry
* In LocalSettingsGenerator, fixed PHP escaping of extension name.
Krinkle [Fri, 19 Nov 2010 00:18:42 +0000 (00:18 +0000)]
Follow-up r76987. Apparently this works better in Firefox 2.
Krinkle [Fri, 19 Nov 2010 00:12:43 +0000 (00:12 +0000)]
jquery.placeholder.js rewritten
* Instead of calling placeholder() and passing the placeholder-text to it (which meant having to manage text-messages in javascript as well and calling it for each different one), it is now expected that the placeholder-attribute already exists on the page generated by PHP. placeholder() is then called on all input-elements with that attribute to provide fallback for browsers that don't support it.
Trevor Parscal [Thu, 18 Nov 2010 22:59:26 +0000 (22:59 +0000)]
Moved rightClickEdit
Trevor Parscal [Thu, 18 Nov 2010 22:04:46 +0000 (22:04 +0000)]
Moved rightClickEdit
Krinkle [Thu, 18 Nov 2010 22:04:22 +0000 (22:04 +0000)]
Follow-up on r76972, renaming files inside the folder accordingly
Trevor Parscal [Thu, 18 Nov 2010 22:03:57 +0000 (22:03 +0000)]
Cleaned up the code a bit, and added a return false to prevent other bindings from being fired.
Krinkle [Thu, 18 Nov 2010 22:02:53 +0000 (22:02 +0000)]
renaming mediawiki.specials to mediawiki.special (matches the Special-pagename and the 'singlular' convention)
Trevor Parscal [Thu, 18 Nov 2010 21:54:28 +0000 (21:54 +0000)]
Renamed mediawiki.views.* to mediawiki.action.* to better relate to the action= URL param
Raimond Spekking [Thu, 18 Nov 2010 21:11:56 +0000 (21:11 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-18 20:47:00 UTC)
Aaron Schulz [Thu, 18 Nov 2010 20:34:02 +0000 (20:34 +0000)]
getDiffBody() cleanups:
* marked it explicitly public
* cleaned up return types on failure
* broke long lines
Max Semenik [Thu, 18 Nov 2010 19:58:27 +0000 (19:58 +0000)]
Release notes for r68872
Markus Glaser [Thu, 18 Nov 2010 16:12:41 +0000 (16:12 +0000)]
* simple smoke test for file upload
Jure Kajzer [Thu, 18 Nov 2010 13:17:16 +0000 (13:17 +0000)]
* Oracle: prefetching column names in ORAResult so i can release statement after constructor.
This fixes too many open cursors issue, importing of large sets now works.
Sam Reed [Thu, 18 Nov 2010 02:32:58 +0000 (02:32 +0000)]
Reverting r76928, causes segfault
Trevor Parscal [Thu, 18 Nov 2010 00:27:32 +0000 (00:27 +0000)]
Updated jquery.tipsy and added it to the Resources manifest.
Aaron Schulz [Thu, 18 Nov 2010 00:25:58 +0000 (00:25 +0000)]
(bug 25920) Moved forward ref to a nested ref to really get v6 regex to compile on older PCRE versions
Aaron Schulz [Thu, 18 Nov 2010 00:08:37 +0000 (00:08 +0000)]
* Moved author count check to new Title::countAuthorsBetween() function
* Added static DifferenceEngine::intermediateEditsMsg() function
* diff-multi msg use by FlaggedRevs wasn't updated after $2 param was added. Fixed this.
* Minor cleanups to getMultiNotice()
Antoine Musso [Wed, 17 Nov 2010 21:12:52 +0000 (21:12 +0000)]
some code comments, fix some indentation issues
Raimond Spekking [Wed, 17 Nov 2010 20:30:02 +0000 (20:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-17 19:51:00 UTC)
Alexandre Emsenhuber [Wed, 17 Nov 2010 18:30:20 +0000 (18:30 +0000)]
FileRepo stuff no longer uses WikiError since ages
Tim Starling [Wed, 17 Nov 2010 11:43:57 +0000 (11:43 +0000)]
Fix for r76088: if you want the Vector stylesheets you have to use the Vector document structure, not a mix of Vector, Monobook and JustPlainBroken.
Aaron Schulz [Wed, 17 Nov 2010 09:12:18 +0000 (09:12 +0000)]
* Reduced some pointless regex capture overhead
* Made preg_replace calls easier to verify w.r.t. captures
* (bug 25920) Made RE_IPV6_ADD avoid conditions on whether a named group matched anything, which requires PCRE 6.7+ (not bundled with PHP 5.1.0)
Aaron Schulz [Wed, 17 Nov 2010 01:02:55 +0000 (01:02 +0000)]
Added two key ipv6 tests
Krinkle [Wed, 17 Nov 2010 00:41:42 +0000 (00:41 +0000)]
Follow-up on r76326 - Fixing milliseconds zero padding for mw.log
Derk-Jan Hartman [Wed, 17 Nov 2010 00:23:30 +0000 (00:23 +0000)]
When displaying non-local File pages, add link rel=canonical.
Solves bug 25960
Sam Reed [Tue, 16 Nov 2010 23:02:08 +0000 (23:02 +0000)]
Clearing up this working copy. Adding a couple of braces
Antoine Musso [Tue, 16 Nov 2010 21:20:45 +0000 (21:20 +0000)]
reorganise targets, use variables for common objects, add comments.
Max Semenik [Tue, 16 Nov 2010 20:40:20 +0000 (20:40 +0000)]
Fixed passing of parameter array to wfMessage()
Raimond Spekking [Tue, 16 Nov 2010 20:33:22 +0000 (20:33 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-16 20:13:00 UTC)
Alexandre Emsenhuber [Tue, 16 Nov 2010 20:14:13 +0000 (20:14 +0000)]
Fixed some doxygen warnings
Aaron Schulz [Tue, 16 Nov 2010 18:28:25 +0000 (18:28 +0000)]
Moved /0 prefix tests to valid...it just means "everything"
Max Semenik [Tue, 16 Nov 2010 18:13:35 +0000 (18:13 +0000)]
Added --env-checks parameter to install.php that checks for prerequisites instead of installing
Platonides [Tue, 16 Nov 2010 17:44:08 +0000 (17:44 +0000)]
The default value of isPermaLink is true, not including it does nothing.
http://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt
Max Semenik [Tue, 16 Nov 2010 16:54:48 +0000 (16:54 +0000)]
Follow-up r76805: removed outdated comment, introduced new group "Search"
Roan Kattouw [Tue, 16 Nov 2010 16:48:20 +0000 (16:48 +0000)]
Fix stupid get vs. set typo in nextJobDB.php
Platonides [Tue, 16 Nov 2010 16:16:09 +0000 (16:16 +0000)]
Revert r76393 and make $wgUpgradeKey like $wgSecretKey. Followup for r76391
Max Semenik [Tue, 16 Nov 2010 16:06:46 +0000 (16:06 +0000)]
Fixed SearchUpdateTest, it doesn't mess with database anymore. More fixes in the line of r76617.
Chad Horohoe [Tue, 16 Nov 2010 16:02:48 +0000 (16:02 +0000)]
Fix copy+paste error from r76798
Chad Horohoe [Tue, 16 Nov 2010 15:50:32 +0000 (15:50 +0000)]
Environment checks don't need to be public
Rotem Liss [Tue, 16 Nov 2010 15:38:49 +0000 (15:38 +0000)]
Localization update for he.
Platonides [Tue, 16 Nov 2010 15:33:29 +0000 (15:33 +0000)]
Follow up r76708
1) IPTest::testValidBlocks
Undefined variable: invalid in phase3/maintenance/tests/phpunit/includes/IPTest.php:174
2) IPTest::testInvalidBlocks
Undefined variable: invalid in phase3/maintenance/tests/phpunit/includes/IPTest.php:197
Note that the 30.242.52.14/0 test does not pass (it is deemed a valid block)
Chad Horohoe [Tue, 16 Nov 2010 15:32:19 +0000 (15:32 +0000)]
Tab to space, might as well be consistent
Chad Horohoe [Tue, 16 Nov 2010 15:29:48 +0000 (15:29 +0000)]
Move preference for PEAR higher up the list, apt and yum repos tend to be out of date
Chad Horohoe [Tue, 16 Nov 2010 15:10:46 +0000 (15:10 +0000)]
More is_a() -> instanceof
Roan Kattouw [Tue, 16 Nov 2010 14:23:34 +0000 (14:23 +0000)]
Followup r76782: is_a() -> instanceof (we dropped PHP 4 support over 3 years ago), or -> ||
Sam Reed [Tue, 16 Nov 2010 14:06:21 +0000 (14:06 +0000)]
Variablise $navigationBar
Add a couple of braces
Chad Horohoe [Tue, 16 Nov 2010 13:44:51 +0000 (13:44 +0000)]
Fix for r69917: Should be using DB_ADMIN if we were using $wgUseRootUser
Aaron Schulz [Tue, 16 Nov 2010 10:51:24 +0000 (10:51 +0000)]
* Fixed ipv6 range test calls
* Made testisIPAddress test results more readable on failure
Neil Kandalgaonkar [Tue, 16 Nov 2010 07:11:39 +0000 (07:11 +0000)]
removed mac-specific temp dir path for debug log
Neil Kandalgaonkar [Tue, 16 Nov 2010 07:09:46 +0000 (07:09 +0000)]
fixed typo
Neil Kandalgaonkar [Tue, 16 Nov 2010 06:57:46 +0000 (06:57 +0000)]
Fixed bug#25784 (thumbnails of stashed files had wrong description URLs).
This fixes the more general problem that the imageinfo returned with stashed uploads was inaccurate, since it was relying on
code that only worked with non-stashed files.
So, I had to:
- move the ApiQueryStashImageInfo module into core. Which others had asked for anyway, and was anticipated sometime later.
- add lines to AutoLoader and ApiQuery to accomodate the new module
- add an ugly if/then to UploadBase -- based on the type of uploaded file, it will use a different API module to simulate a getImageInfo call.
I left a TODO that this situation wasn't ideal, but the way things are now, imageInfo is constructed by the API modules, when it should probably
really be the File modules. Then the API can wrap that info into various formats.
- add a few new lines to the tests to check imageinfo information in both regular and stashed upload files
Neil Kandalgaonkar [Tue, 16 Nov 2010 01:15:58 +0000 (01:15 +0000)]
removed URL hackery, now using SpecialPage::getTitleFor(). Followup to r75906
Neil Kandalgaonkar [Tue, 16 Nov 2010 00:24:37 +0000 (00:24 +0000)]
Followups mostly to r75906.
* Improved logic around error messages, and understandability of those messages.
* Removed FIXME on Content-Length header. When we serve the file
this way, it seems to be necessary to explicitly set the Content-Length. I tried
removing it and unsurprisingly it did not appear.
I am unsure what RoanKattouw is referring to when he says PHP can do this.
How can PHP know what the Content-Length is going to be, unless we set this explicitly?
Neil Kandalgaonkar [Mon, 15 Nov 2010 23:49:16 +0000 (23:49 +0000)]
updated comments, error messages. Removing exposure of actual paths in error message, while convenient for a developer it probably should not be exposed to the public.
Aaron Schulz [Mon, 15 Nov 2010 23:20:23 +0000 (23:20 +0000)]
Removed weird unused "IPv4toIPv6" function
Aaron Schulz [Mon, 15 Nov 2010 21:18:31 +0000 (21:18 +0000)]
* added more isValid()/isPrivate() tests
* added isValidBlock()/isIPv4() tests
Antoine Musso [Mon, 15 Nov 2010 21:14:29 +0000 (21:14 +0000)]
Use accessor when trying to get a private property.
I kept hitting my browser cache when verifying my change, this
mean I have committed r76700 without testing it :(
Raimond Spekking [Mon, 15 Nov 2010 21:10:22 +0000 (21:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-15 20:53:00 UTC)
Platonides [Mon, 15 Nov 2010 20:40:49 +0000 (20:40 +0000)]
If this was needed to use MockSearch, it will also be needed after it has run, so other tests can get the real db they expect.
Max Semenik [Mon, 15 Nov 2010 20:39:34 +0000 (20:39 +0000)]
Rm superfuluous tab
Aaron Schulz [Mon, 15 Nov 2010 20:37:11 +0000 (20:37 +0000)]
typo: RE_IPV4_BLOCK -> RE_IP_BLOCK
Antoine Musso [Mon, 15 Nov 2010 20:13:58 +0000 (20:13 +0000)]
Change HistoryPage properties scope to private as well as some obvious functions scopes.
Add a few comments.
Antoine Musso [Mon, 15 Nov 2010 19:51:47 +0000 (19:51 +0000)]
Stylize. Add a couple braces around if/else statements.
Antoine Musso [Mon, 15 Nov 2010 19:47:15 +0000 (19:47 +0000)]
Get ride of $counter in functions calls. Follow up r65417.
Sam Reed [Mon, 15 Nov 2010 15:49:52 +0000 (15:49 +0000)]
Add a few bits of parameter documentation
Chad Horohoe [Mon, 15 Nov 2010 12:20:00 +0000 (12:20 +0000)]
(bug 25935) Fix comment in cleanupRemovedModules.php
Raimond Spekking [Sun, 14 Nov 2010 21:10:48 +0000 (21:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-14 20:53:00 UTC)
Benjamin Lees [Sun, 14 Nov 2010 21:00:31 +0000 (21:00 +0000)]
Grammar fix
Raimond Spekking [Sun, 14 Nov 2010 19:45:55 +0000 (19:45 +0000)]
Follow-up r76434, r76570,r76668: Pass skin object per CR
Raimond Spekking [Sun, 14 Nov 2010 19:28:32 +0000 (19:28 +0000)]
Follow-up r76434, r76570: Add skinname per CR
Sam Reed [Sun, 14 Nov 2010 19:00:27 +0000 (19:00 +0000)]
Add Yuri Astrakhan to CREDITS per request at [en.wikipedia.org/w/index.php?title=User_talk:Reedy&action=historysubmit&diff=
396740314&oldid=
396417142] (he wrote most of the original API stuff)
Alexandre Emsenhuber [Sun, 14 Nov 2010 18:58:28 +0000 (18:58 +0000)]
Follow-up r76633: change function signature so that it's easier to track the problem
Aaron Schulz [Sat, 13 Nov 2010 23:31:13 +0000 (23:31 +0000)]
Minor cleanups
Roan Kattouw [Sat, 13 Nov 2010 22:12:39 +0000 (22:12 +0000)]
Remove duplicate occurrence of 'u' from $htmlpairsStatic in Sanitizer::removeHTMLtags(). Reported by Dan Bolser on IRC
Raimond Spekking [Sat, 13 Nov 2010 20:42:57 +0000 (20:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-13 20:25:00 UTC)
Alexandre Emsenhuber [Sat, 13 Nov 2010 17:35:27 +0000 (17:35 +0000)]
Seems I forgot to commit this file in r76634
Alexandre Emsenhuber [Sat, 13 Nov 2010 17:31:04 +0000 (17:31 +0000)]
* (bug 20591) There's now a different message on Special:MovePage when $wgFixDoubleRedirects is set to false.
Based on a patch by The Evil IP address: https://bugzilla.wikimedia.org/attachment.cgi?id=7807
Alexandre Emsenhuber [Sat, 13 Nov 2010 17:22:08 +0000 (17:22 +0000)]
* (bug 25908) OutputPage::getHeadLinks() now requires a Skin object as first parameter
Chad Horohoe [Sat, 13 Nov 2010 16:32:40 +0000 (16:32 +0000)]
Fix undefined $max when doing --dfn-only
Max Semenik [Sat, 13 Nov 2010 13:24:21 +0000 (13:24 +0000)]
Mention load.php, rm repetition
Antoine Musso [Sat, 13 Nov 2010 13:13:12 +0000 (13:13 +0000)]
revert r71054. Although unused, the variable might be used later.
Sam Reed [Sat, 13 Nov 2010 12:50:50 +0000 (12:50 +0000)]
Followup r76612, nfi what a stromg is
Antoine Musso [Sat, 13 Nov 2010 12:45:10 +0000 (12:45 +0000)]
With PHPUnit 3.5.0, use its autoloader (like r74831).
Fix 'make test' for me.
Antoine Musso [Sat, 13 Nov 2010 10:41:38 +0000 (10:41 +0000)]
Minor variable typo
Antoine Musso [Sat, 13 Nov 2010 10:33:30 +0000 (10:33 +0000)]
justify help memcached console help
Max Semenik [Sat, 13 Nov 2010 08:32:40 +0000 (08:32 +0000)]
Tests: removed assignments of null to globals that are usually not null in tearDown() methods. This practice leads to other tests having to play whack-a-mole by initializing random variables they don't need directly just to avoid crashing.
Rob Lanphier [Sat, 13 Nov 2010 06:25:12 +0000 (06:25 +0000)]
Followup to r76111. Making the result parameter on getThumbUrl optional
Sam Reed [Sat, 13 Nov 2010 00:47:51 +0000 (00:47 +0000)]
Fixup some more documentation